Conversation
…rray subscripts
`resolve_param_expansion_name` didn't resolve namerefs before looking up
array names for subscript access and bulk operations (`[@]`, `[*]`).
This caused `${ref[key]:-default}` and `${ref[key]:+alt}` to always
treat the value as unset when `ref` was a nameref to an associative array.
The fix resolves namerefs for `arr_name` in both the `[@]`/`[*]` bulk
access path and the individual `[key]` subscript path within
`resolve_param_expansion_name`, matching the behavior of `expand_variable`.
Closes #801
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve_param_expansion_namedidn't resolve namerefs before looking up array names for subscript access and bulk operations ([@],[*]). This caused${ref[key]:-default}and${ref[key]:+alt}to always treat the value as unset whenrefwas a nameref to an associative array.Changes
arr_namein the[@]/[*]bulk access patharr_namein the individual[key]subscript path:-,:+, and[@]:-through namerefsTest plan
nameref.test.sh(3 were failing before fix, all pass after)local -nnameref with associative arrays — harness patterns #801 test cases: 16/16 passcargo clippy --all-features -- -D warningscleancargo fmt --checkcleanCloses #801